lkml.org 
[lkml]   [2020]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] mm: Remove src/dst mm parameter in copy_page_range()
On Fri, Oct 02, 2020 at 03:26:47PM -0400, Peter Xu wrote:
> Both of the mm pointers are not needed after commit 7a4830c380f3 ("mm/fork:
> Pass new vma pointer into copy_page_range()").
>
> Jason Gunthorpe also reported that the ordering of copy_page_range() is odd.
> Since working at it, reorder the parameters to be logical, by (1) always put
> the dst_* fields to be before src_* fields, and (2) keep the same type of
> parameters together.
>
> CC: Jason Gunthorpe <jgg@ziepe.ca>
> CC: Andrew Morton <akpm@linux-foundation.org>
> Reported-by: Kirill A. Shutemov <kirill@shutemov.name>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> v2:
> - further reorder some parameters and line format [Jason]
> ---
> include/linux/mm.h | 4 +-
> kernel/fork.c | 2 +-
> mm/memory.c | 139 ++++++++++++++++++++++++---------------------
> 3 files changed, 76 insertions(+), 69 deletions(-)

Thanks, looks more readable to me

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason

\
 
 \ /
  Last update: 2020-10-03 01:34    [W:0.049 / U:0.848 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site