lkml.org 
[lkml]   [2020]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 0/2] module: some refactoring in module_sig_check()
From
Date
On 10/14/20 11:35 AM, Joe Perches wrote:

[...]
>>>> Here are 2 patches against the 'modules-next' branch of Jessica Yu's 'linux.git' repo.
>>>> I'm doing some little refactoring in module_sig_check()...
>>>>
>>>> [1/2] module: merge repetitive strings in module_sig_check()
>>>> [2/2] module: unindent comments in module_sig_check()
>>>
>>> I think this code is rather cryptic and could be made clearer.
>>>
>>> How about:
>>> ---
>>> kernel/module.c | 51 ++++++++++++++++++++++++++-------------------------
>>> 1 file changed, 26 insertions(+), 25 deletions(-)
>>
>> Looks good. Do you want to post complete patch(es)? :-)
>
> I don't like posting actual patches on top of other people.
> It's a complete and compilable diff, it's just unsigned.

It does too many things simultaneously, I'll need to decompose it...

> If you want a Signed-off-by: here's one:
>
> Signed-off-by: Joe Perches <joe@perches.com>

I think I'll rather use Suggested-by: where appropriate...

MBR, Sergei

\
 
 \ /
  Last update: 2020-10-14 21:45    [W:0.074 / U:3.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site