lkml.org 
[lkml]   [2020]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/2] media: dt-bindings: media: i2c: Add bindings for ADDI9036
Hi Bogdan,

On Fri, Oct 09, 2020 at 02:29:55PM +0300, Bogdan Togorean wrote:
> Add YAML device tree bindings for Analog Devices Inc. ADDI9036 CCD TOF
> front-end.
>
> Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
> ---
> v3: drop I2C reg description
> specify maxItems on reset-gpios property
> ---
> .../bindings/media/i2c/adi,addi9036.yaml | 76 +++++++++++++++++++
> 1 file changed, 76 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/adi,addi9036.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/adi,addi9036.yaml b/Documentation/devicetree/bindings/media/i2c/adi,addi9036.yaml
> new file mode 100644
> index 000000000000..067b08ad8f53
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/adi,addi9036.yaml
> @@ -0,0 +1,76 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/adi,addi9036.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices ADDI9036 VGA CCD Time of Flight Sensor
> +
> +maintainers:
> + - Bogdan Togorean <bogdan.togorean@analog.com>
> +
> +description: |-
> + The ADDI9036 is a complete, 45 MHz, front-end solution for charge coupled
> + device (CCD) time of flight (TOF) imaging applications. It is programmable
> + through I2C interface. Image data is sent through MIPI CSI-2 2 lanes and
> + can output two RAW12 packed data streams. One is IR and the other is Depth.
> + Each data stream is on a separate or same MIPI Virtual Channel, depending
> + on configuration and each have 640x480 resolution.
> +
> +properties:
> + compatible:
> + const: adi,addi9036
> +
> + reg:
> + maxItems: 1
> +
> + reset-gpios:
> + maxItems: 1
> + description: |-
> + Reference to the GPIO connected to the RST/SYNC pin, if any.
> + Must be released (set high) after all supplies are applied.
> +
> + # See ../video-interfaces.txt for more details
> + port:
> + type: object
> + properties:
> + endpoint:
> + type: object
> + properties:
> + data-lanes:
> + description: |-
> + The sensor supports two-lane operation.
> + For two-lane operation the property must be set to <1 2>.
> + items:
> + - const: 1
> + - const: 2

If, as we discussed, the hardware does not support one lane operation (or
other lane configurations I presume), you don't need data-lanes property.

> +
> +required:
> + - compatible
> + - reg
> + - port
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + addi9036: addi9036_tof@64 {
> + compatible = "adi,addi9036";
> + reg = <0x64>;
> +
> + reset-gpios = <&gpio 41 1>;
> +
> + port {
> + addi9036_ep: endpoint {
> + remote-endpoint = <&csi1_ep>;
> + data-lanes = <1 2>;
> + };
> + };
> + };
> + };
> +
> +...
> --
> 2.28.0
>

--
Sakari Ailus

\
 
 \ /
  Last update: 2020-10-13 18:17    [W:0.081 / U:2.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site