lkml.org 
[lkml]   [2020]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/3] mm/slub: Clarify verification reporting
From
Date
On 10/9/20 9:54 PM, Kees Cook wrote:
> Instead of repeating "Redzone" and "Poison", clarify which sides of
> those zones got tripped. Additionally fix column alignment in the
> trailer.
>
> Before:
>
> BUG test (Tainted: G B ): Redzone overwritten
> ...
> Redzone (____ptrval____): bb bb bb bb bb bb bb bb ........
> Object (____ptrval____): f6 f4 a5 40 1d e8 ...@..
> Redzone (____ptrval____): 1a aa ..
> Padding (____ptrval____): 00 00 00 00 00 00 00 00 ........
>
> After:
>
> BUG test (Tainted: G B ): Right Redzone overwritten
> ...
> Redzone (____ptrval____): bb bb bb bb bb bb bb bb ........
> Object (____ptrval____): f6 f4 a5 40 1d e8 ...@..
> Redzone (____ptrval____): 1a aa ..
> Padding (____ptrval____): 00 00 00 00 00 00 00 00 ........
>
> Fixes: d86bd1bece6f ("mm/slub: support left redzone")
> Fixes: ffc79d288000 ("slub: use print_hex_dump")
> Fixes: 2492268472e7 ("SLUB: change error reporting format to follow lockdep loosely")

Not sure about those Fixes: tag as this is mainly an enhancement. I'd only use
those for real bug fixes.

> Signed-off-by: Kees Cook <keescook@chromium.org>

Acked-by: Vlastimil Babka <vbabka@suse.cz>

\
 
 \ /
  Last update: 2020-10-13 18:14    [W:0.133 / U:25.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site