lkml.org 
[lkml]   [2020]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] thunderbolt: Add the missed ida_simple_remove() in ring_request_msix()
On Tue, Oct 13, 2020 at 10:45:18AM +0800, Jing Xiangfeng wrote:
> ring_request_msix() misses to call ida_simple_remove() in an error path.
> Add the missed function call to fix it.

...

> ring->irq = pci_irq_vector(ring->nhi->pdev, ring->vector);
> - if (ring->irq < 0)
> + if (ring->irq < 0) {
> + ida_simple_remove(&nhi->msix_ida, ret);
> return ring->irq;
> + }
>
> irqflags = no_suspend ? IRQF_NO_SUSPEND : 0;
> return request_irq(ring->irq, ring_msix, irqflags, "thunderbolt", ring);

According to your logic don't you need it here as well?

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2020-10-13 13:43    [W:0.060 / U:1.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site