lkml.org 
[lkml]   [2020]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v11 2/3] ASoC: qcom: dt-bindings: Add sc7180 machine bindings
From
Date
Hi Cheng,

Sorry for such late review w.r.t compatibles,

On 14/09/2020 09:06, Cheng-Yi Chiang wrote:
> +---
> +$id:http://devicetree.org/schemas/sound/qcom,sc7180.yaml#
> +$schema:http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Technologies Inc. SC7180 ASoC sound card driver
> +
> +maintainers:
> + - Rohit kumar<rohitkr@codeaurora.org>
> + - Cheng-Yi Chiang<cychiang@chromium.org>
> +
> +description:
> + This binding describes the SC7180 sound card which uses LPASS for audio.
> +
> +properties:
> + compatible:
> + const: qcom,sc7180-sndcard-rt5682-m98357-1mic

This information can come from the dai link description itself, why
should compatible string have this information?

Can't we have better compatible string with actual board name or use the
same compatible name as used by other boards?

Can you give us some details on the advantages of doing this way?

Or am I missing something?

AFAIU, you should add proper board name / model name to the compatible
string rather than describe how its connected. Connection is already
part of dai link definition.

On the other hand model property can include variant information.
This can also be used to set card long name which will help in UCM2.

The reason I had to bring this up is because the use-space (ucm in this
case) will not be in a position to differentiate between different board
variants to select correct mixer controls, so its going to be a pain!


Thanks,
srini

\
 
 \ /
  Last update: 2020-10-13 12:37    [W:0.125 / U:3.968 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site