[lkml]   [2020]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] mm: memcg/slab: fix slab statistics in !SMP configuration
Hi Roman,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on mmotm/master]

base: git:// master
config: i386-randconfig-s002-20200930 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
# apt-get install sparse
# sparse version: v0.6.2-201-g24bdaac6-dirty
git remote add linux-review
git fetch --no-tags linux-review Roman-Gushchin/mm-memcg-slab-fix-slab-statistics-in-SMP-configuration/20201002-044114
git checkout 3e4248734433fea1624e4971258042af2f231e02
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <>

All errors (new ones prefixed by >>):

In file included from include/linux/mm.h:1317,
from include/linux/memcontrol.h:20,
from include/linux/swap.h:9,
from include/linux/suspend.h:5,
from arch/x86/kernel/asm-offsets.c:13:
include/linux/vmstat.h: In function '__mod_node_page_state':
>> include/linux/vmstat.h:295:6: error: implicit declaration of function 'vmstat_item_in_bytes' [-Werror=implicit-function-declaration]
295 | if (vmstat_item_in_bytes(item)) {
| ^~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[2]: *** [scripts/ arch/x86/kernel/asm-offsets.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1139: prepare0] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:179: sub-make] Error 2
make: Target 'prepare' not remade because of errors.

vim +/vmstat_item_in_bytes +295 include/linux/vmstat.h

292 static inline void __mod_node_page_state(struct pglist_data *pgdat,
293 enum node_stat_item item, int delta)
294 {
> 295 if (vmstat_item_in_bytes(item)) {
296 VM_WARN_ON_ONCE(delta & (PAGE_SIZE - 1));
297 delta >>= PAGE_SHIFT;
298 }
300 node_page_state_add(delta, pgdat, item);
301 }

0-DAY CI Kernel Test Service, Intel Corporation
[unhandled content-type:application/gzip]
 \ /
  Last update: 2020-10-02 02:10    [W:0.123 / U:5.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site