Messages in this thread |  | | From | james qian wang <> | Subject | Re: [PATCH] drm/komeda: mark PM functions as __maybe_unused | Date | Wed, 8 Jan 2020 09:56:17 +0000 |
| |
On Tue, Jan 07, 2020 at 10:53:19PM +0100, Arnd Bergmann wrote: > Without this, we get a couple of warnings when CONFIG_PM > is disabled: > > drivers/gpu/drm/arm/display/komeda/komeda_drv.c:156:12: error: 'komeda_rt_pm_resume' defined but not used [-Werror=unused-function] > static int komeda_rt_pm_resume(struct device *dev) > ^~~~~~~~~~~~~~~~~~~ > drivers/gpu/drm/arm/display/komeda/komeda_drv.c:149:12: error: 'komeda_rt_pm_suspend' defined but not used [-Werror=unused-function] > static int komeda_rt_pm_suspend(struct device *dev) > ^~~~~~~~~~~~~~~~~~~~ > > Fixes: efb465088518 ("drm/komeda: Add runtime_pm support") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/gpu/drm/arm/display/komeda/komeda_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c > index ea5cd1e17304..e7933930a657 100644 > --- a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c > @@ -146,14 +146,14 @@ static const struct of_device_id komeda_of_match[] = { > > MODULE_DEVICE_TABLE(of, komeda_of_match); > > -static int komeda_rt_pm_suspend(struct device *dev) > +static int __maybe_unused komeda_rt_pm_suspend(struct device *dev) > { > struct komeda_drv *mdrv = dev_get_drvdata(dev); > > return komeda_dev_suspend(mdrv->mdev); > } > > -static int komeda_rt_pm_resume(struct device *dev) > +static int __maybe_unused komeda_rt_pm_resume(struct device *dev) > { > struct komeda_drv *mdrv = dev_get_drvdata(dev); >
Hi Arnd:
Thank you for the patch.
Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>
James > -- > 2.20.0
|  |