lkml.org 
[lkml]   [2020]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH linux-can/testing] can: tcan4x5x: Disable the INH pin device-state GPIO is unavailable
From
Date
Marc

On 12/29/19 10:05 AM, Marc Kleine-Budde wrote:
> On 12/29/19 4:32 PM, Marc Kleine-Budde wrote:
>> On 12/12/19 5:15 PM, Dan Murphy wrote:
>>> static int tcan4x5x_parse_config(struct m_can_classdev *cdev)
>>> {
>>> struct tcan4x5x_priv *tcan4x5x = cdev->device_data;
>>> @@ -383,8 +393,10 @@ static int tcan4x5x_parse_config(struct m_can_classdev *cdev)
>>> tcan4x5x->device_state_gpio = devm_gpiod_get_optional(cdev->dev,
>>> "device-state",
>>> GPIOD_IN);
>>> - if (IS_ERR(tcan4x5x->device_state_gpio))
>>> + if (IS_ERR(tcan4x5x->device_state_gpio)) {
>>> tcan4x5x->device_state_gpio = NULL;
>>> + tcan4x5x_disable_state(cdev);
>>> + }
>> For some reason, this hunk doesn't apply, due to the additional:
>>
>>>> tcan4x5x->power = devm_regulator_get_optional(cdev->dev,
>>>> "vsup");
> ...which was my fault. :) Please have a look at
>
> https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git/log/?h=testing
>
> ...if I've collected every m_can related patch.

Is this still relevant or have you pulled this in?

It looks good to me.

Dan


\
 
 \ /
  Last update: 2020-01-08 21:51    [W:0.086 / U:0.944 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site