Messages in this thread |  | | Subject | Re: [PATCH v3 0/3] ata: ahci_brcm: Follow-up changes for BCM7216 | From | Hans de Goede <> | Date | Tue, 7 Jan 2020 19:47:18 +0100 |
| |
Hi,
On 07-01-2020 19:30, Florian Fainelli wrote: > Hi Jens, Philipp, > > These three patches are a follow-up to my previous series titled: ata: > ahci_brcm: Fixes and new device support. > > After submitting the BCM7216 RESCAL reset driver, Philipp the reset > controller maintained indicated that the reset line should be self > de-asserting and so reset_control_reset() should be used instead. > > These three patches update the driver in that regard. It would be great if > you could apply those and get them queued up for 5.6 since they are > directly related to the previous series. > > Changes in v3: > - introduced a preliminary patch making use of the proper reset control > API in order to manage the optional reset controller line > - updated patches after introducing that preliminary patch > > Changes in v2: > - updated error path after moving the reset line control
Series looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> > Thanks! > > Florian Fainelli (3): > ata: ahci_brcm: Correct reset control API usage > ata: ahci_brcm: Perform reset after obtaining resources > ata: ahci_brcm: BCM7216 reset is self de-asserting > > drivers/ata/ahci_brcm.c | 42 +++++++++++++++++++++++++---------------- > 1 file changed, 26 insertions(+), 16 deletions(-) >
|  |