Messages in this thread Patch in this message |  | | From | Colin King <> | Subject | [PATCH][V2] usb: ohci-da8xx: ensure error return on variable error is set | Date | Tue, 7 Jan 2020 10:30:35 +0000 |
| |
From: Colin Ian King <colin.king@canonical.com>
Currently when an error in da8xx_ohci->oc_gpio occurs it causes an uninitialized error return in variable 'error' to be returned. Fix this by ensuring the error variable is set to the error value in da8xx_ohci->oc_gpio.
Addresses-Coverity: ("Uninitialized scalar variable") Fixes: d193abf1c913 ("usb: ohci-da8xx: add vbus and overcurrent gpios") Signed-off-by: Colin Ian King <colin.king@canonical.com> ---
V2: fix typo and grammar in commit message
--- drivers/usb/host/ohci-da8xx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/ohci-da8xx.c b/drivers/usb/host/ohci-da8xx.c index 38183ac438c6..9cdf787055b7 100644 --- a/drivers/usb/host/ohci-da8xx.c +++ b/drivers/usb/host/ohci-da8xx.c @@ -415,8 +415,10 @@ static int ohci_da8xx_probe(struct platform_device *pdev) } da8xx_ohci->oc_gpio = devm_gpiod_get_optional(dev, "oc", GPIOD_IN); - if (IS_ERR(da8xx_ohci->oc_gpio)) + if (IS_ERR(da8xx_ohci->oc_gpio)) { + error = PTR_ERR(da8xx_ohci->oc_gpio); goto err; + } if (da8xx_ohci->oc_gpio) { oc_irq = gpiod_to_irq(da8xx_ohci->oc_gpio); -- 2.24.0
|  |