Messages in this thread |  | | Date | Tue, 7 Jan 2020 10:58:35 +0100 | From | Michał Mirosław <> | Subject | Re: [PATCH 2/2] opp: quiet down WARN when no valid OPPs remain |
| |
On Tue, Jan 07, 2020 at 12:11:29PM +0530, Viresh Kumar wrote: > On 03-01-20, 20:36, Michał Mirosław wrote: > > Per CPU screenful of backtraces is not really that useful. Replace > > WARN with a diagnostic discriminating common causes of empty OPP table. > But why should a platform have an OPP table in DT where none of them works for > it ? I added the warn intentionally here just for that case.
Hmm. I guess we can make it WARN_ON_ONCE instead of removing it, but I don't think the backtrace is ever useful in this case. Empty table can be because eg. you run old DT on newer hardware version. This is why it's still communicated via dev_err().
Best Regards, Michał Mirosław
|  |