lkml.org 
[lkml]   [2020]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [EXT] [PATCH] spi: nxp-fspi: Ensure width is respected in spi-mem operations
Date
Hi Michael,

> -----Original Message-----
> From: linux-kernel-owner@vger.kernel.org <linux-kernel-
> owner@vger.kernel.org> On Behalf Of Michael Walle
> Sent: Thursday, December 12, 2019 1:28 AM
> To: linux-spi@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: Yogesh Gaur <yogeshgaur.83@gmail.com>; Ashish Kumar
> <ashish.kumar@nxp.com>; Mark Brown <broonie@kernel.org>; Michael
> Walle <michael@walle.cc>
> Subject: [EXT] [PATCH] spi: nxp-fspi: Ensure width is respected in spi-mem
> operations
>
> Caution: EXT Email
>
> Make use of a core helper to ensure the desired width is respected when
> calling spi-mem operators.
>
> Otherwise only the SPI controller will be matched with the flash chip, which
> might lead to wrong widths. Also consider the width specified by the user in
> the device tree.

Could you please mention the flash and modes you tested. Does it support DUAL/QUAD mode?
I couldn't test these modes as NXP LS1028ARDB has "mt35xu02g" which supports SINGLE and OCTAL modes only.

Thanks
Kuldeep

>
> Fixes: a5356aef6a90 ("spi: spi-mem: Add driver for NXP FlexSPI controller")
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> drivers/spi/spi-nxp-fspi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c index
> c36bb1bb464e..8c5084a3a617 100644
> --- a/drivers/spi/spi-nxp-fspi.c
> +++ b/drivers/spi/spi-nxp-fspi.c
> @@ -439,7 +439,7 @@ static bool nxp_fspi_supports_op(struct spi_mem
> *mem,
> op->data.nbytes > f->devtype_data->txfifo)
> return false;
>
> - return true;
> + return spi_mem_default_supports_op(mem, op);
> }
>
> /* Instead of busy looping invoke readl_poll_timeout functionality. */
> --
> 2.20.1

\
 
 \ /
  Last update: 2020-01-07 06:39    [W:0.054 / U:2.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site