Messages in this thread |  | | Date | Tue, 7 Jan 2020 10:40:33 +0100 | From | Thierry Reding <> | Subject | Re: [PATCH] coccinnelle: Remove ptr_ret script |
| |
On Tue, Jan 07, 2020 at 08:36:29AM +0100, Maxime Ripard wrote: > The ptr_ret script script addresses a number of situations where we end up > testing an error pointer, and if it's an error returning it, or return 0 > otherwise to transform it into a PTR_ERR_OR_ZERO call. > > So it will convert a block like this: > > if (IS_ERR(err)) > return PTR_ERR(err); > > return 0; > > into > > return PTR_ERR_OR_ZERO(err); > > While this is technically correct, it has a number of drawbacks. First, it > merges the error and success path, which will make it harder for a reviewer > or reader to grasp. > > It's also more difficult to extend if we were to add some code between the > error check and the function return, making the author essentially revert > that patch before adding new lines, while it would have been a trivial > addition otherwise for the rewiever. > > Therefore, since that script is only about cosmetic in the first place, > let's remove it since it's not worth it. > > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> > Cc: Mark Brown <broonie@kernel.org> > Signed-off-by: Maxime Ripard <maxime@cerno.tech> > --- > scripts/coccinelle/api/ptr_ret.cocci | 97 ---------------------------- > 1 file changed, 97 deletions(-) > delete mode 100644 scripts/coccinelle/api/ptr_ret.cocci
Acked-by: Thierry Reding <treding@nvidia.com> [unhandled content-type:application/pgp-signature] |  |