Messages in this thread |  | | From | "Singh, Balbir" <> | Subject | Re: [resend v1 5/5] drivers/scsi/sd.c: Convert to use disk_set_capacity | Date | Wed, 8 Jan 2020 04:20:47 +0000 |
| |
On Tue, 2020-01-07 at 22:15 -0500, Martin K. Petersen wrote: > Balbir, > > > > We already emit an SDEV_EVT_CAPACITY_CHANGE_REPORTED event if device > > > capacity changes. However, this event does not automatically cause > > > revalidation. > > > > The proposed idea is to not reinforce revalidation, unless explictly > > specified (in the thread before Bob Liu had suggestions). The goal is > > to notify user space of changes via RESIZE. SCSI sd can opt out of > > this IOW, I can remove this if you feel > > SDEV_EVT_CAPACITY_CHANGE_REPORTED is sufficient for current use cases. > > I have no particular objection to the code change. I was just observing > that in the context of sd.c, RESIZE=1 is more of a "your request to > resize was successful" notification due to the requirement of an > explicit userland action in case a device reports a capacity change. >
That is true, yes I agree with your observation.
Balbir Singh.
|  |