Messages in this thread |  | | Date | Tue, 7 Jan 2020 16:02:51 -0800 | From | Bjorn Andersson <> | Subject | Re: [PATCH v2] reset: qcom-aoss: Allow CONFIG_RESET_QCOM_AOSS to be a tristate |
| |
On Tue 07 Jan 11:13 PST 2020, John Stultz wrote:
> Allow CONFIG_RESET_QCOM_AOSS to be set as as =m > to allow for the driver to be loaded from a modules. > > Also replaces the builtin_platform_driver() line with > module_platform_driver() > > Cc: Todd Kjos <tkjos@google.com> > Cc: Alistair Delva <adelva@google.com> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Amit Pundir <amit.pundir@linaro.org> > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Signed-off-by: John Stultz <john.stultz@linaro.org> > --- > v2: Fix builtin_platform_driver line in driver code > --- > drivers/reset/Kconfig | 2 +- > drivers/reset/reset-qcom-aoss.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig > index 3ad7817ce1f0..45e70524af36 100644 > --- a/drivers/reset/Kconfig > +++ b/drivers/reset/Kconfig > @@ -99,7 +99,7 @@ config RESET_PISTACHIO > This enables the reset driver for ImgTec Pistachio SoCs. > > config RESET_QCOM_AOSS > - bool "Qcom AOSS Reset Driver" > + tristate "Qcom AOSS Reset Driver" > depends on ARCH_QCOM || COMPILE_TEST > help > This enables the AOSS (always on subsystem) reset driver > diff --git a/drivers/reset/reset-qcom-aoss.c b/drivers/reset/reset-qcom-aoss.c > index 36db96750450..76367f17fc73 100644 > --- a/drivers/reset/reset-qcom-aoss.c > +++ b/drivers/reset/reset-qcom-aoss.c > @@ -127,7 +127,7 @@ static struct platform_driver qcom_aoss_reset_driver = { > }, > }; > > -builtin_platform_driver(qcom_aoss_reset_driver); > +module_platform_driver(qcom_aoss_reset_driver);
Thought we had this covered already, sorry for missing it yesterday.
In addition to module_platform_driver() you also need a MODULE_DEVICE_TABLE(of, qcom_aoss_reset_of_match), or the driver won't be loaded automatically.
Regards, Bjorn
|  |