Messages in this thread |  | | Subject | Re: [PATCH 1/2] ata: brcm: mark PM functions as __maybe_unused | From | Florian Fainelli <> | Date | Tue, 7 Jan 2020 14:51:39 -0800 |
| |
On 1/7/20 2:14 PM, Arnd Bergmann wrote: > The new shutdown callback causes a link failure: > > drivers/ata/ahci_brcm.c: In function 'brcm_ahci_shutdown': > drivers/ata/ahci_brcm.c:552:8: error: implicit declaration of function 'brcm_ahci_suspend'; did you mean 'brcm_ahci_shutdown'? [-Werror=implicit-function-declaration] > ret = brcm_ahci_suspend(&pdev->dev); > ^~~~~~~~~~~~~~~~~ > > Remove the incorrect #ifdef and use __maybe_unused annotations > instead to make this more robust. > > Fixes: 7de9b1688c1d ("ata: ahci_brcm: Add a shutdown callback") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
good catch, thanks! -- Florian
|  |