[lkml]   [2020]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/4] IMA: Define an IMA hook to measure keys
On Tue, 2020-01-07 at 11:43 -0800, Lakshmi Ramasubramanian wrote:
> diff --git a/security/integrity/ima/Kconfig
> b/security/integrity/ima/Kconfig
> index 838476d780e5..73a3974712d8 100644
> --- a/security/integrity/ima/Kconfig
> +++ b/security/integrity/ima/Kconfig
> @@ -310,3 +310,12 @@ config IMA_APPRAISE_SIGNED_INIT
> default n
> help
> This option requires user-space init to be signed.
> +
> + bool "Enable measuring asymmetric keys on key create or
> update"

I don't believe there's a need to expose this to the person configuring
the kernel, is there? It's just one more option no-one really wants to
have to understand. Without the text following bool and the help, this
becomes a hidden config option, which is what I think it should be.

> + depends on IMA=y

Not that it matters, but IMA is a bool, so this can be simply depends
on IMA


We only need the =y here becase the variable is a tristate, so this
becomes n for both the n and m cases.

> + default y
> + help
> + This option enables measuring asymmetric keys when
> + the key is created or updated.

And drop the help entry. For future information, help text must be tab
followed by two spaces, not three ... checkpatch doesn't actually catch
this, unfortunately.


 \ /
  Last update: 2020-01-07 23:27    [W:0.070 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site