[lkml]   [2020]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 4.14 25/74] MIPS: Avoid VDSO ABI breakage due to global register variable
    From: Paul Burton <>

    commit bbcc5672b0063b0e9d65dc8787a4f09c3b5bb5cc upstream.

    Declaring __current_thread_info as a global register variable has the
    effect of preventing GCC from saving & restoring its value in cases
    where the ABI would typically do so.

    To quote GCC documentation:

    > If the register is a call-saved register, call ABI is affected: the
    > register will not be restored in function epilogue sequences after the
    > variable has been assigned. Therefore, functions cannot safely return
    > to callers that assume standard ABI.

    When our position independent VDSO is built for the n32 or n64 ABIs all
    functions it exposes should be preserving the value of $gp/$28 for their
    caller, but in the presence of the __current_thread_info global register
    variable GCC stops doing so & simply clobbers $gp/$28 when calculating
    the address of the GOT.

    In cases where the VDSO returns success this problem will typically be
    masked by the caller in libc returning & restoring $gp/$28 itself, but
    that is by no means guaranteed. In cases where the VDSO returns an error
    libc will typically contain a fallback path which will now fail
    (typically with a bad memory access) if it attempts anything which
    relies upon the value of $gp/$28 - eg. accessing anything via the GOT.

    One fix for this would be to move the declaration of
    __current_thread_info inside the current_thread_info() function,
    demoting it from global register variable to local register variable &
    avoiding inadvertently creating a non-standard calling ABI for the VDSO.
    Unfortunately this causes issues for clang, which doesn't support local
    register variables as pointed out by commit fe92da0f355e ("MIPS: Changed
    current_thread_info() to an equivalent supported by both clang and GCC")
    which introduced the global register variable before we had a VDSO to
    worry about.

    Instead, fix this by continuing to use the global register variable for
    the kernel proper but declare __current_thread_info as a simple extern
    variable when building the VDSO. It should never be referenced, and will
    cause a link error if it is. This resolves the calling convention issue
    for the VDSO without having any impact upon the build of the kernel
    itself for either clang or gcc.

    Signed-off-by: Paul Burton <>
    Fixes: ebb5e78cc634 ("MIPS: Initial implementation of a VDSO")
    Reported-by: Jason A. Donenfeld <>
    Reviewed-by: Jason A. Donenfeld <>
    Tested-by: Jason A. Donenfeld <>
    Cc: Arnd Bergmann <>
    Cc: Christian Brauner <>
    Cc: Vincenzo Frascino <>
    Cc: <> # v4.4+
    Signed-off-by: Greg Kroah-Hartman <>

    arch/mips/include/asm/thread_info.h | 20 +++++++++++++++++++-
    1 file changed, 19 insertions(+), 1 deletion(-)

    --- a/arch/mips/include/asm/thread_info.h
    +++ b/arch/mips/include/asm/thread_info.h
    @@ -52,8 +52,26 @@ struct thread_info {
    #define init_thread_info (init_thread_union.thread_info)
    #define init_stack (init_thread_union.stack)

    -/* How to get the thread information struct from C. */
    + * A pointer to the struct thread_info for the currently executing thread is
    + * held in register $28/$gp.
    + *
    + * We declare __current_thread_info as a global register variable rather than a
    + * local register variable within current_thread_info() because clang doesn't
    + * support explicit local register variables.
    + *
    + * When building the VDSO we take care not to declare the global register
    + * variable because this causes GCC to not preserve the value of $28/$gp in
    + * functions that change its value (which is common in the PIC VDSO when
    + * accessing the GOT). Since the VDSO shouldn't be accessing
    + * __current_thread_info anyway we declare it extern in order to cause a link
    + * failure if it's referenced.
    + */
    +#ifdef __VDSO__
    +extern struct thread_info *__current_thread_info;
    register struct thread_info *__current_thread_info __asm__("$28");

    static inline struct thread_info *current_thread_info(void)

     \ /
      Last update: 2020-01-07 22:40    [W:2.315 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site