Messages in this thread Patch in this message |  | | Date | Tue, 7 Jan 2020 16:25:06 -0500 (EST) | From | Alan Stern <> | Subject | Re: WARNING in usbhid_raw_request/usb_submit_urb (2) |
| |
On Tue, 7 Jan 2020, syzbot wrote:
> Hello, > > syzbot has tested the proposed patch but the reproducer still triggered > crash: > WARNING in usbhid_raw_request/usb_submit_urb
All right, now for a slightly larger change.
Alan Stern
#syz test: https://github.com/google/kasan.git ecdf2214
Index: usb-devel/drivers/usb/core/urb.c =================================================================== --- usb-devel.orig/drivers/usb/core/urb.c +++ usb-devel/drivers/usb/core/urb.c @@ -205,7 +205,7 @@ int usb_urb_ep_type_check(const struct u ep = usb_pipe_endpoint(urb->dev, urb->pipe); if (!ep) - return -EINVAL; + return -EBADF; if (usb_pipetype(urb->pipe) != pipetypes[usb_endpoint_type(&ep->desc)]) return -EINVAL; return 0;
|  |