lkml.org 
[lkml]   [2020]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] selinuxfs: use scnprinft to get real length in sel_read_class
From
Date
On 1/5/20 8:56 PM, liuyang34 wrote:
> as the return value of snprintf maybe over the size of TMPBUFLEN,
> use scnprintf to instead of it

Is there a reason you didn't make the same change to sel_read_perm()?

>
> Signed-off-by: liuyang34 <liuyang34@xiaomi.com>
> ---
> security/selinux/selinuxfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c
> index ee94fa4..977c32d 100644
> --- a/security/selinux/selinuxfs.c
> +++ b/security/selinux/selinuxfs.c
> @@ -1672,7 +1672,7 @@ static ssize_t sel_read_class(struct file *file, char __user *buf,
> {
> unsigned long ino = file_inode(file)->i_ino;
> char res[TMPBUFLEN];
> - ssize_t len = snprintf(res, sizeof(res), "%d", sel_ino_to_class(ino));
> + ssize_t len = scnprintf(res, sizeof(res), "%d", sel_ino_to_class(ino));
> return simple_read_from_buffer(buf, count, ppos, res, len);
> }
>
>

\
 
 \ /
  Last update: 2020-01-06 21:49    [W:0.140 / U:2.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site