lkml.org 
[lkml]   [2020]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 4/5] ARM: dts: mmp3: Add HSIC controllers
On Fri, Dec 20, 2019 at 08:05:50AM +0100, Lubomir Rintel wrote:
> On Fri, 2019-12-20 at 07:53 +0100, Lubomir Rintel wrote:
> > There are two on MMP3, along with the PHYs. The PHYs are made compatible
> > with the NOP transceiver, since there's no driver for the time being and
> > they're likely configured by the firmware.
> >
> > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> > ---
> > arch/arm/boot/dts/mmp3.dtsi | 44 +++++++++++++++++++++++++++++++++++++
> > 1 file changed, 44 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/mmp3.dtsi b/arch/arm/boot/dts/mmp3.dtsi
> > index d9762de0ed34b..36c50706e60e0 100644
> > --- a/arch/arm/boot/dts/mmp3.dtsi
> > +++ b/arch/arm/boot/dts/mmp3.dtsi
> > @@ -201,6 +201,50 @@ usb_otg0: usb-otg@d4208000 {
> > status = "disabled";
> > };
> >
> > + hsic_phy0: hsic-phy@f0001800 {
> > + compatible = "marvell,mmp3-hsic-phy",
> > + "usb-nop-xceiv",
>
> I managed to mess this up right before sending it out. ^^^
> Sorry for that. There should be a semicolon there. I'll fix this up on
> next patch spin.

Missed the comments when applying, but I fixed it up locally with the below
patch. Please send new versions incremental on top of it.

I applied the series to the mmp/hsic (and mmp/hsic-fixed) branch in our tree if
you want to use that as a base.


-Olof


---

From e2ce979bf176af4b8eb7aea866919d618c08f752 Mon Sep 17 00:00:00 2001
From: Olof Johansson <olof@lixom.net>
Date: Mon, 6 Jan 2020 11:14:10 -0800
Subject: [PATCH] ARM: dts: mmp3: Fix typos

Fixes build failures due to syntax errors.

Fixes: 3240d5b872f2 ("ARM: dts: mmp3: Add HSIC controllers")
Signed-off-by: Olof Johansson <olof@lixom.net>
---
arch/arm/boot/dts/mmp3.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/mmp3.dtsi b/arch/arm/boot/dts/mmp3.dtsi
index 36c50706e60e..1eba7fb6629b 100644
--- a/arch/arm/boot/dts/mmp3.dtsi
+++ b/arch/arm/boot/dts/mmp3.dtsi
@@ -203,7 +203,7 @@

hsic_phy0: hsic-phy@f0001800 {
compatible = "marvell,mmp3-hsic-phy",
- "usb-nop-xceiv",
+ "usb-nop-xceiv";
reg = <0xf0001800 0x40>;
#phy-cells = <0>;
status = "disabled";
@@ -225,7 +225,7 @@

hsic_phy1: hsic-phy@f0002800 {
compatible = "marvell,mmp3-hsic-phy",
- "usb-nop-xceiv",
+ "usb-nop-xceiv";
reg = <0xf0002800 0x40>;
#phy-cells = <0>;
status = "disabled";
--
2.22.GIT
\
 
 \ /
  Last update: 2020-01-06 20:23    [W:0.043 / U:10.784 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site