lkml.org 
[lkml]   [2020]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next v2 1/3] wil6210: get rid of begin() and complete() ethtool_ops
From
Date
On 1/5/20 10:39 PM, Michal Kubecek wrote:
> The wil6210 driver locks a mutex in begin() ethtool_ops callback and
> unlocks it in complete() so that all ethtool requests are serialized. This
> is not going to work correctly with netlink interface; e.g. when ioctl
> triggers a netlink notification, netlink code would call begin() again
> while the mutex taken by ioctl code is still held by the same task.
>
> Let's get rid of the begin() and complete() callbacks and move the mutex
> locking into the remaining ethtool_ops handlers except get_drvinfo which
> only copies strings that are not changing so that there is no need for
> serialization.
>
> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian

\
 
 \ /
  Last update: 2020-01-06 19:31    [W:0.084 / U:2.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site