Messages in this thread |  | | Date | Mon, 06 Jan 2020 09:45:25 -0800 | From | asutoshd@codeauro ... | Subject | Re: [PATCH v2 1/2] scsi: ufs: pass device information to apply_dev_quirks |
| |
On 2020-01-05 16:27, Stanley Chu wrote: > Pass UFS device information to vendor-specific variant callback > "apply_dev_quirks" because some platform vendors need to know such > information to apply special handlings or quirks in specific devices. > > In the same time, modify existed vendor implementation according to > the new interface. > > Cc: Alim Akhtar <alim.akhtar@samsung.com> > Cc: Asutosh Das <asutoshd@codeaurora.org> > Cc: Avri Altman <avri.altman@wdc.com> > Cc: Bart Van Assche <bvanassche@acm.org> > Cc: Bean Huo <beanhuo@micron.com> > Cc: Can Guo <cang@codeaurora.org> > Cc: Matthias Brugger <matthias.bgg@gmail.com> > Reviewed-by: Avri Altman <avri.altman@wdc.com> > Signed-off-by: Stanley Chu <stanley.chu@mediatek.com> > --- > drivers/scsi/ufs/ufs-qcom.c | 3 ++- > drivers/scsi/ufs/ufshcd.c | 5 +++-- > drivers/scsi/ufs/ufshcd.h | 7 ++++--- > 3 files changed, 9 insertions(+), 6 deletions(-) > > diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c > index c69c29a1ceb9..ebb5c66e069f 100644 > --- a/drivers/scsi/ufs/ufs-qcom.c > +++ b/drivers/scsi/ufs/ufs-qcom.c > @@ -949,7 +949,8 @@ static int > ufs_qcom_quirk_host_pa_saveconfigtime(struct ufs_hba *hba) > return err; > } > > -static int ufs_qcom_apply_dev_quirks(struct ufs_hba *hba) > +static int ufs_qcom_apply_dev_quirks(struct ufs_hba *hba, > + struct ufs_dev_desc *card) > { > int err = 0; > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index 1b97f2dc0b63..9abf0ea8c308 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -6803,7 +6803,8 @@ static int > ufshcd_quirk_tune_host_pa_tactivate(struct ufs_hba *hba) > return ret; > } > > -static void ufshcd_tune_unipro_params(struct ufs_hba *hba) > +static void ufshcd_tune_unipro_params(struct ufs_hba *hba, > + struct ufs_dev_desc *card) > { > if (ufshcd_is_unipro_pa_params_tuning_req(hba)) { > ufshcd_tune_pa_tactivate(hba); > @@ -6817,7 +6818,7 @@ static void ufshcd_tune_unipro_params(struct > ufs_hba *hba) > if (hba->dev_quirks & UFS_DEVICE_QUIRK_HOST_PA_TACTIVATE) > ufshcd_quirk_tune_host_pa_tactivate(hba); > > - ufshcd_vops_apply_dev_quirks(hba); > + ufshcd_vops_apply_dev_quirks(hba, card); > } > > static void ufshcd_clear_dbg_ufs_stats(struct ufs_hba *hba) > diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h > index e05cafddc87b..4f3fa71303da 100644 > --- a/drivers/scsi/ufs/ufshcd.h > +++ b/drivers/scsi/ufs/ufshcd.h > @@ -320,7 +320,7 @@ struct ufs_hba_variant_ops { > void (*setup_task_mgmt)(struct ufs_hba *, int, u8); > void (*hibern8_notify)(struct ufs_hba *, enum uic_cmd_dme, > enum ufs_notify_change_status); > - int (*apply_dev_quirks)(struct ufs_hba *); > + int (*apply_dev_quirks)(struct ufs_hba *, struct ufs_dev_desc *); > int (*suspend)(struct ufs_hba *, enum ufs_pm_op); > int (*resume)(struct ufs_hba *, enum ufs_pm_op); > void (*dbg_register_dump)(struct ufs_hba *hba); > @@ -1052,10 +1052,11 @@ static inline void > ufshcd_vops_hibern8_notify(struct ufs_hba *hba, > return hba->vops->hibern8_notify(hba, cmd, status); > } > > -static inline int ufshcd_vops_apply_dev_quirks(struct ufs_hba *hba) > +static inline int ufshcd_vops_apply_dev_quirks(struct ufs_hba *hba, > + struct ufs_dev_desc *card) > { > if (hba->vops && hba->vops->apply_dev_quirks) > - return hba->vops->apply_dev_quirks(hba); > + return hba->vops->apply_dev_quirks(hba, card); > return 0; > }
Please separate the vendor code (ufs-qcom, in this case) to a separate patch.
-asd
|  |