[lkml]   [2020]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] usb: ohci-da8xx: ensure error return on variable error is set
On 01/06/2020 04:06 PM, Colin King wrote:

> From: Colin Ian King <>
> Currently when an error in da8xx_ohci->oc_gpi occurs causes an

s/gpi/gpio/. And you missed a noun between 2 verbs.

> uninitialized error value in variable 'error' to be returned.
> Fix this by ensuring the error variable is set to the error value
> in da8xx_ohci->oc_gpi.

oc_gpio again.

> Addresses-Coverity: ("Uninitialized scalar variable")
> Fixes: d193abf1c913 ("usb: ohci-da8xx: add vbus and overcurrent gpios")
> Signed-off-by: Colin Ian King <>

MBR, Sergei

 \ /
  Last update: 2020-01-06 17:07    [W:0.050 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site