lkml.org 
[lkml]   [2020]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] ARM: dts: sun8i: R40: Add SPI controllers nodes and pinmuxes
On Mon, Jan 06, 2020 at 01:42:07PM +0000, Andre Przywara wrote:
> On Mon, 6 Jan 2020 21:37:38 +0800
> Chen-Yu Tsai <wens@csie.org> wrote:
>
> Hi,
>
> > On Mon, Jan 6, 2020 at 4:56 PM Maxime Ripard <mripard@kernel.org> wrote:
> > >
> > > On Mon, Jan 06, 2020 at 12:38:49AM +0000, Andre Przywara wrote:
> > > > The Allwinner R40 SoC contains four SPI controllers, using the newer
> > > > sun6i design (but at the legacy addresses).
> > > > The controller seems to be fully compatible to the A64 one, so no driver
> > > > changes are necessary.
> > > > The first three controllers can be used on two sets of pins, but SPI3 is
> > > > only routed to one set on Port A.
> > > > Only the pin groups for SPI0 on PortC and SPI1 on PortI are added here,
> > > > because those seem to be the only one exposed on the Bananapi boards.
> > > >
> > > > Tested by connecting a SPI flash to a Bananapi M2 Berry SPI0 and SPI1
> > > > header pins.
> > > >
> > > > Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> > >
> > > Applied, thanks!
> > > Maxime
> >
> > Looks like this patch doesn't build. The SPI device nodes reference
> > a non-existent DMA node.
>
> Argh, shoot, sorry for that. Looks like a rebase artefact (I
> originally had the DMA controller in, but then saw that this is
> actually not used by the SPI driver, so removed it).
>
> Thanks for testing!
>
> Maxime, shall I send a fixup or redo the patch?

Send a fixup, I'll squash it with the previous patch, thanks!
Maxime
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-01-06 14:52    [W:0.063 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site