Messages in this thread |  | | Subject | Re: [PATCH] coccinelle: semantic patch to check for inappropriate do_div() calls | From | Markus Elfring <> | Date | Sun, 5 Jan 2020 11:33:41 +0100 |
| |
> +virtual context > +virtual org > +virtual report
The operation mode “patch” is not supported here. Should the term “semantic code search” be used instead in the subject again?
> +@@ > +( > +* do_div(f, l); > +| > +* do_div(f, ul); > +| > +* do_div(f, ul64); > +| > +* do_div(f, sl64); > +)
I suggest to avoid the specification of duplicate SmPL code.
+@@ +*do_div(f, \( l \| ul \| ul64 \| sl64 \) );
Will any more case distinctions become helpful?
> +@script:python depends on report@ > +p << r.p; > +@@ > + > +msg="WARNING: WARNING: do_div() does a 64-by-32 division, which may truncation the divisor to 32-bit" > +coccilib.report.print_report(p[0], msg)
Please improve the message construction.
Regards, Markus
|  |