[lkml]   [2020]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2 2/7] bus: Introduce firewall controller framework
On Fri, Jan 31, 2020 at 08:37:27AM +0000, Benjamin GAIGNARD wrote:
> On 1/29/20 12:17 PM, Mark Brown wrote:
> > On Wed, Jan 29, 2020 at 10:52:40AM +0100, Greg KH wrote:
> >
> >> It just needs to be part of the bus logic for the specific bus that this
> >> "firewall" is on. Just like we do the same thing for USB or thunderbolt
> >> devices. Put this in the bus-specific code please.
> > I'd expect that this is going to affect at least platform and AMBA
> > buses.
> Correct me if I'm wrong but creating a new type of bus would mean
> that all the drivers living on this bus must be changed to register
> themselves on this bus ?


> Or does a solution exist to let them live on the platform bus and call
> firewalled bus before been probed ?

Why do people want to abuse the platform bus so much? If a device is on
a bus that can have such a controller, then it is on a real bus, use it!

> All the impacted drivers could work on the existing bus with or without
> the firewall so I don't want to break

break what?

> that.

Odd line-break :)

Just register the driver on both busses, no big deal.

Stop abusing the platform bus code for things that it is not for.


greg k-h

 \ /
  Last update: 2020-01-31 10:07    [W:0.130 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site