lkml.org 
[lkml]   [2020]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [resend v1 1/5] block/genhd: Notify udev about capacity change
Date
On Fri, 2020-01-03 at 06:16 +0000, Chaitanya Kulkarni wrote:
> On 01/01/2020 11:53 PM, Balbir Singh wrote:
> > Allow block/genhd to notify user space (via udev) about disk size changes
> > using a new helper disk_set_capacity(), which is a wrapper on top
> > of set_capacity(). disk_set_capacity() will only notify via udev if
> > the current capacity or the target capacity is not zero.
> >
> > Suggested-by: Christoph Hellwig<hch@lst.de>
> > Signed-off-by: Someswarudu Sangaraju<ssomesh@amazon.com>
> > Signed-off-by: Balbir Singh<sblbir@amazon.com>
> > ---
>
> Since disk_set_capacity(() is on the same line as set_capacity()
> we should follow the same convention, which is :-
>
> 1. Avoid exporting symbol.
> 2. Mark new function in-line.
>
> Unless there is a very specific reason for breaking the pattern.
>

I don't see the benefit of marking it as inline. I expect this code to be
potentially expanded to provide callbacks into file system code for expansion
(something you brought up), marking it as inline might be a limitation.

I'd rather not clutter the headers with this code, but I am open to what the
maintainers think as well.

Balbir Singh.

\
 
 \ /
  Last update: 2020-01-04 05:44    [W:0.169 / U:53.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site