lkml.org 
[lkml]   [2020]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fixing coding style. Signed-off-by:
On Thu, Jan 02, 2020 at 12:16:53PM +0100, Greg KH wrote:
> On Thu, Jan 02, 2020 at 12:59:29PM +0530, Amrita Patole wrote:
> > From: Amrita Patole <amritapatole@gmail.com>
> >
> > ---
> > drivers/staging/qlge/qlge_mpi.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c
> > index 9e422bbbb6ab..f63db2c79fac 100644
> > --- a/drivers/staging/qlge/qlge_mpi.c
> > +++ b/drivers/staging/qlge/qlge_mpi.c
> > @@ -136,7 +136,8 @@ static int ql_get_mb_sts(struct ql_adapter *qdev, struct mbox_params *mbcp)
> > ql_read_mpi_reg(qdev, qdev->mailbox_out + i,
> > &mbcp->mbox_out[i]);
> > if (status) {
> > - netif_err(qdev, drv, qdev->ndev, "Failed mailbox read.\n");
> > + netif_err(qdev, drv, qdev->ndev,
> > + "Failed mailbox read. \n");


netif_err(qdev, drv, qdev->ndev,
"Failed mailbox read. \n");
"Failed mailbox read. \n");


I'm pretty sure this will introduce a couplee new checkpatch warnings...
It should be indented:
[tab][tab][tab][tab][space][space]"Failed mailbox read.\n");

No space after the period, please.

regards,
dan carpenter

\
 
 \ /
  Last update: 2020-01-03 14:26    [W:4.835 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site