lkml.org 
[lkml]   [2020]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 04/12] tracing: Add dynamic event command creation interface
On Thu, 30 Jan 2020 11:40:28 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:

> > +int dynevent_arg_add(struct dynevent_cmd *cmd,
> > + struct dynevent_arg *arg)
> > +{
> > + int ret = 0;
> > + int delta;
> > + char *q;
> > +
> > + if (arg->check_arg) {
> > + ret = arg->check_arg(arg);
>
> Hmm, this seems a bit odd. The check_arg() arg object member check
> the validity of the object itself. What about moving those checker
> into dynevent_cmd instead of dynevent_arg?
> (Or, just pass the appropriate checker as the 3rd parameter of
> this function)

Masami,

Thanks for reviewing these patches.

Tom,

Please send updates on top of this series. I've already pulled them in
my queue and there going through my test suite now. It will be easier
just to add changes on top than to send another version at this point.

You can see what I'm testing via my repo on branch ftrace/core.

-- Steve

\
 
 \ /
  Last update: 2020-01-30 03:59    [W:0.158 / U:1.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site