lkml.org 
[lkml]   [2020]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] gpiolib: remove unnecessary argument from set_config call
On Wed, Jan 29, 2020 at 11:55:49AM +0100, Bartosz Golaszewski wrote:
> pon., 20 sty 2020 o 11:46 Kent Gibson <warthog618@gmail.com> napisał(a):
> >
> > Remove unnecessary argument when setting PIN_CONFIG_BIAS_DISABLE.
> >
> > Fixes: 2148ad7790ea ("gpiolib: add support for disabling line bias")
> > Signed-off-by: Kent Gibson <warthog618@gmail.com>
> > ---
> >
> > No argument is expected by pinctrl, so removing it should be harmless.
> >
>
> This doesn't really fix any bug, does it? If not, then I'll just take
> it for v5.7 after the merge window.
>

This is just fixing what I suspect was a cut-and-paste error on my part
that wasn't picked up during review - until I had a closer look
following Geert and Andy's recent comments on some of your proposed
changes. So it is just a tidy up.

It could only a problem if a pinctrl is making use of the unnecessary
argument, and there are no such pinctrls that I am aware of.

Merge it in whenever it is convenient.

Cheers,
Kent.

\
 
 \ /
  Last update: 2020-01-29 13:34    [W:0.086 / U:5.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site