lkml.org 
[lkml]   [2020]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 026/271] clk: highbank: fix refcount leak in hb_clk_init()
    Date
    From: Yangtao Li <tiny.windzz@gmail.com>

    [ Upstream commit 5eb8ba90958de1285120dae5d3a5d2b1a360b3b4 ]

    The of_find_compatible_node() returns a node pointer with refcount
    incremented, but there is the lack of use of the of_node_put() when
    done. Add the missing of_node_put() to release the refcount.

    Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
    Fixes: 26cae166cff9 ("ARM: highbank: remove custom .init_time hook")
    Signed-off-by: Stephen Boyd <sboyd@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/clk/clk-highbank.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/clk/clk-highbank.c b/drivers/clk/clk-highbank.c
    index 727ed8e1bb726..8e4581004695c 100644
    --- a/drivers/clk/clk-highbank.c
    +++ b/drivers/clk/clk-highbank.c
    @@ -293,6 +293,7 @@ static __init struct clk *hb_clk_init(struct device_node *node, const struct clk
    /* Map system registers */
    srnp = of_find_compatible_node(NULL, NULL, "calxeda,hb-sregs");
    hb_clk->reg = of_iomap(srnp, 0);
    + of_node_put(srnp);
    BUG_ON(!hb_clk->reg);
    hb_clk->reg += reg;

    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-28 15:16    [W:2.430 / U:1.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site