lkml.org 
[lkml]   [2020]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v3 1/4] Tools: hv: Reopen the devices if read() or write() returns errors
Date
> From: Michael Kelley <mikelley@microsoft.com>
> Sent: Saturday, January 25, 2020 8:49 PM
> > +reopen_fcopy_fd:
> > + /* Remove any possible partially-copied file on error */
> > + hv_copy_cancel();
>
> Since you have removed the calls to close(fcopy_fd) after a
> pread() or pwrite() failure that were in v2 of the patch, I was
> expecting to see
>
> if (fcopy_fd != -1)
> close(fcopy_fd)

I missed this... Thanks for catching it!

> here, like you've done with the kvp and vss code. And
> remember to initialize fcopy_fd to -1. :-)
>
> Michael

Will do it in v4.

Thanks,
-- Dexuan

\
 
 \ /
  Last update: 2020-01-26 06:00    [W:0.069 / U:0.800 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site