[lkml]   [2020]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [for-next][PATCH 7/7] tracing: Use pr_err() instead of WARN() for memory failures
On Sun, 26 Jan 2020 13:07:36 -0800
Joe Perches <> wrote:

> > That sounds more generic. This is specific for my own tracing tests to
> > look for. As the point is, it is *not* to dump_stack, and still report
> > the error.
> __GFP_NOWARN is available too.

I honestly don't care if there's a dump_stack or not. I just removed the
WARN_ON. If the allocation causes a dump_stack() then that's fine, but
I still like to have a bit more information at what failed to allocate,
than just a offset into a function.

The point of this patch was simply to remove WARN_ON() that caused
fuzzers to fail.

-- Steve

 \ /
  Last update: 2020-01-26 22:41    [W:0.055 / U:0.772 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site