lkml.org 
[lkml]   [2020]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [for-next][PATCH 7/7] tracing: Use pr_err() instead of WARN() for memory failures
On Sun, 26 Jan 2020 12:38:55 -0800
Joe Perches <joe@perches.com> wrote:

> On Sun, 2020-01-26 at 14:19 -0500, Steven Rostedt wrote:
> > From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
> >
> > As warnings can trigger panics, especially when "panic_on_warn" is set,
> > memory failure warnings can cause panics and fail fuzz testers that are
> > stressing memory.
> >
> > Create a MEM_FAIL() macro to use instead of WARN() in the tracing code
> > (perhaps this should be a kernel wide macro?), and use that for memory
> > failure issues. This should stop failing fuzz tests due to warnings.
>
> It looks as if most of these could just be removed instead
> as there is an existing dump_stack() on failure.

That sounds more generic. This is specific for my own tracing tests to
look for. As the point is, it is *not* to dump_stack, and still report
the error.

-- Steve

\
 
 \ /
  Last update: 2020-01-26 21:51    [W:0.055 / U:4.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site