lkml.org 
[lkml]   [2020]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH mk-II 08/17] asm-generic/tlb: Provide MMU_GATHER_TABLE_FREE
On Thu, Dec 12, 2019 at 10:32:05AM +0100, Peter Zijlstra wrote:
> As described in the comment, the correct order for freeing pages is:
>
> 1) unhook page
> 2) TLB invalidate page
> 3) free page
>
> This order equally applies to page directories.
>
> Currently there are two correct options:
>
> - use tlb_remove_page(), when all page directores are full pages and
> there are no futher contraints placed by things like software
> walkers (HAVE_FAST_GUP).
>
> - use MMU_GATHER_RCU_TABLE_FREE and tlb_remove_table() when the
> architecture does not do IPI based TLB invalidate and has
> HAVE_FAST_GUP (or software TLB fill).
>
> This however leaves architectures that don't have page based
> directories but don't need RCU in a bind. For those, provide
> MMU_GATHER_TABLE_FREE, which provides the independent batching for
> directories without the additional RCU freeing.
>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> ---

Various sparc64 builds (allnoconfig, tinyconfig, as well as builds
with SMP disabled):

mm/mmu_gather.c: In function '__tlb_remove_table_free':
mm/mmu_gather.c:101:3: error: implicit declaration of function '__tlb_remove_table'; did you mean 'tlb_remove_table'?

Guenter

\
 
 \ /
  Last update: 2020-01-26 16:52    [W:0.058 / U:6.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site