lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 479/639] xfrm interface: ifname may be wrong in logs
    Date
    From: Nicolas Dichtel <nicolas.dichtel@6wind.com>

    [ Upstream commit e0aaa332e6a97dae57ad59cdb19e21f83c3d081c ]

    The ifname is copied when the interface is created, but is never updated
    later. In fact, this property is used only in one error message, where the
    netdevice pointer is available, thus let's use it.

    Fixes: f203b76d7809 ("xfrm: Add virtual xfrm interfaces")
    Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
    Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    include/net/xfrm.h | 1 -
    net/xfrm/xfrm_interface.c | 10 +---------
    2 files changed, 1 insertion(+), 10 deletions(-)

    diff --git a/include/net/xfrm.h b/include/net/xfrm.h
    index fb9b19a3b7496..48dc1ce2170d8 100644
    --- a/include/net/xfrm.h
    +++ b/include/net/xfrm.h
    @@ -1054,7 +1054,6 @@ static inline void xfrm_dst_destroy(struct xfrm_dst *xdst)
    void xfrm_dst_ifdown(struct dst_entry *dst, struct net_device *dev);

    struct xfrm_if_parms {
    - char name[IFNAMSIZ]; /* name of XFRM device */
    int link; /* ifindex of underlying L2 interface */
    u32 if_id; /* interface identifyer */
    };
    diff --git a/net/xfrm/xfrm_interface.c b/net/xfrm/xfrm_interface.c
    index d6a3cdf7885c3..4ee512622e93d 100644
    --- a/net/xfrm/xfrm_interface.c
    +++ b/net/xfrm/xfrm_interface.c
    @@ -145,8 +145,6 @@ static int xfrmi_create(struct net_device *dev)
    if (err < 0)
    goto out;

    - strcpy(xi->p.name, dev->name);
    -
    dev_hold(dev);
    xfrmi_link(xfrmn, xi);

    @@ -293,7 +291,7 @@ xfrmi_xmit2(struct sk_buff *skb, struct net_device *dev, struct flowi *fl)
    if (tdev == dev) {
    stats->collisions++;
    net_warn_ratelimited("%s: Local routing loop detected!\n",
    - xi->p.name);
    + dev->name);
    goto tx_err_dst_release;
    }

    @@ -648,12 +646,6 @@ static int xfrmi_newlink(struct net *src_net, struct net_device *dev,
    int err;

    xfrmi_netlink_parms(data, &p);
    -
    - if (!tb[IFLA_IFNAME])
    - return -EINVAL;
    -
    - nla_strlcpy(p.name, tb[IFLA_IFNAME], IFNAMSIZ);
    -
    xi = xfrmi_locate(net, &p);
    if (xi)
    return -EEXIST;
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:28    [W:4.025 / U:0.840 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site