lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 469/639] PCI: mobiveil: Remove the flag MSI_FLAG_MULTI_PCI_MSI
    Date
    From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>

    [ Upstream commit a131fb6364c1be0924dcb969ecf6b988c556a5d5 ]

    The Mobiveil internal MSI controller requires separate target addresses,
    one per MSI vector; this is clearly incompatible with the Multiple MSI
    feature, which requires the same target address for all vectors
    requested by an endpoint (ie the Message Address field in the MSI
    Capability structure), so the multi MSI feature is clearly not
    supported by the host controller driver.

    Remove the flag MSI_FLAG_MULTI_PCI_MSI and with it multi MSI support,
    fixing the misconfiguration.

    Fixes: 1e913e58335f ("PCI: mobiveil: Add MSI support")
    Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
    [lorenzo.pieralisi@arm.com: commit log]
    Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
    Reviewed-by: Minghuan Lian <Minghuan.Lian@nxp.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pci/controller/pcie-mobiveil.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/pci/controller/pcie-mobiveil.c b/drivers/pci/controller/pcie-mobiveil.c
    index a2d1e89d48674..dc228eb500edd 100644
    --- a/drivers/pci/controller/pcie-mobiveil.c
    +++ b/drivers/pci/controller/pcie-mobiveil.c
    @@ -643,7 +643,7 @@ static struct irq_chip mobiveil_msi_irq_chip = {

    static struct msi_domain_info mobiveil_msi_domain_info = {
    .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
    - MSI_FLAG_MULTI_PCI_MSI | MSI_FLAG_PCI_MSIX),
    + MSI_FLAG_PCI_MSIX),
    .chip = &mobiveil_msi_irq_chip,
    };

    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:27    [W:2.175 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site