lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 270/639] jfs: fix bogus variable self-initialization
    Date
    From: Arnd Bergmann <arnd@arndb.de>

    [ Upstream commit a5fdd713d256887b5f012608701149fa939e5645 ]

    A statement was originally added in 2006 to shut up a gcc warning,
    now but now clang warns about it:

    fs/jfs/jfs_txnmgr.c:1932:15: error: variable 'pxd' is uninitialized when used within its own initialization
    [-Werror,-Wuninitialized]
    pxd_t pxd = pxd; /* truncated extent of xad */
    ~~~ ^~~

    Modern versions of gcc are fine without the silly assignment, so just
    drop it. Tested with gcc-4.6 (released 2011), 4.7, 4.8, and 4.9.

    Fixes: c9e3ad6021e5 ("JFS: Get rid of "may be used uninitialized" warnings")
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/jfs/jfs_txnmgr.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/fs/jfs/jfs_txnmgr.c b/fs/jfs/jfs_txnmgr.c
    index a5663cb621d8d..78789c5ed36b0 100644
    --- a/fs/jfs/jfs_txnmgr.c
    +++ b/fs/jfs/jfs_txnmgr.c
    @@ -1928,8 +1928,7 @@ static void xtLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,
    * header ?
    */
    if (tlck->type & tlckTRUNCATE) {
    - /* This odd declaration suppresses a bogus gcc warning */
    - pxd_t pxd = pxd; /* truncated extent of xad */
    + pxd_t pxd; /* truncated extent of xad */
    int twm;

    /*
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:15    [W:2.647 / U:4.996 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site