lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 246/639] NFS: Add missing encode / decode sequence_maxsz to v4.2 operations
    Date
    From: Anna Schumaker <Anna.Schumaker@Netapp.com>

    [ Upstream commit 1a3466aed3a17eed41cd9411f89eb637f58349b0 ]

    These really should have been there from the beginning, but we never
    noticed because there was enough slack in the RPC request for the extra
    bytes. Chuck's recent patch to use au_cslack and au_rslack to compute
    buffer size shrunk the buffer enough that this was now a problem for
    SEEK operations on my test client.

    Fixes: f4ac1674f5da4 ("nfs: Add ALLOCATE support")
    Fixes: 2e72448b07dc3 ("NFS: Add COPY nfs operation")
    Fixes: cb95deea0b4aa ("NFS OFFLOAD_CANCEL xdr")
    Fixes: 624bd5b7b683c ("nfs: Add DEALLOCATE support")
    Fixes: 1c6dcbe5ceff8 ("NFS: Implement SEEK")
    Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
    Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/nfs/nfs42xdr.c | 10 ++++++++++
    1 file changed, 10 insertions(+)

    diff --git a/fs/nfs/nfs42xdr.c b/fs/nfs/nfs42xdr.c
    index 69f72ed2bf879..ec9803088f6b8 100644
    --- a/fs/nfs/nfs42xdr.c
    +++ b/fs/nfs/nfs42xdr.c
    @@ -59,43 +59,53 @@
    #define decode_clone_maxsz (op_decode_hdr_maxsz)

    #define NFS4_enc_allocate_sz (compound_encode_hdr_maxsz + \
    + encode_sequence_maxsz + \
    encode_putfh_maxsz + \
    encode_allocate_maxsz + \
    encode_getattr_maxsz)
    #define NFS4_dec_allocate_sz (compound_decode_hdr_maxsz + \
    + decode_sequence_maxsz + \
    decode_putfh_maxsz + \
    decode_allocate_maxsz + \
    decode_getattr_maxsz)
    #define NFS4_enc_copy_sz (compound_encode_hdr_maxsz + \
    + encode_sequence_maxsz + \
    encode_putfh_maxsz + \
    encode_savefh_maxsz + \
    encode_putfh_maxsz + \
    encode_copy_maxsz + \
    encode_commit_maxsz)
    #define NFS4_dec_copy_sz (compound_decode_hdr_maxsz + \
    + decode_sequence_maxsz + \
    decode_putfh_maxsz + \
    decode_savefh_maxsz + \
    decode_putfh_maxsz + \
    decode_copy_maxsz + \
    decode_commit_maxsz)
    #define NFS4_enc_offload_cancel_sz (compound_encode_hdr_maxsz + \
    + encode_sequence_maxsz + \
    encode_putfh_maxsz + \
    encode_offload_cancel_maxsz)
    #define NFS4_dec_offload_cancel_sz (compound_decode_hdr_maxsz + \
    + decode_sequence_maxsz + \
    decode_putfh_maxsz + \
    decode_offload_cancel_maxsz)
    #define NFS4_enc_deallocate_sz (compound_encode_hdr_maxsz + \
    + encode_sequence_maxsz + \
    encode_putfh_maxsz + \
    encode_deallocate_maxsz + \
    encode_getattr_maxsz)
    #define NFS4_dec_deallocate_sz (compound_decode_hdr_maxsz + \
    + decode_sequence_maxsz + \
    decode_putfh_maxsz + \
    decode_deallocate_maxsz + \
    decode_getattr_maxsz)
    #define NFS4_enc_seek_sz (compound_encode_hdr_maxsz + \
    + encode_sequence_maxsz + \
    encode_putfh_maxsz + \
    encode_seek_maxsz)
    #define NFS4_dec_seek_sz (compound_decode_hdr_maxsz + \
    + decode_sequence_maxsz + \
    decode_putfh_maxsz + \
    decode_seek_maxsz)
    #define NFS4_enc_layoutstats_sz (compound_encode_hdr_maxsz + \
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:13    [W:2.050 / U:6.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site