lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 172/639] rtc: ds1672: fix unintended sign extension
    Date
    From: Colin Ian King <colin.king@canonical.com>

    [ Upstream commit f0c04c276739ed8acbb41b4868e942a55b128dca ]

    Shifting a u8 by 24 will cause the value to be promoted to an integer. If
    the top bit of the u8 is set then the following conversion to an unsigned
    long will sign extend the value causing the upper 32 bits to be set in
    the result.

    Fix this by casting the u8 value to an unsigned long before the shift.

    Detected by CoverityScan, CID#138801 ("Unintended sign extension")

    Fixes: edf1aaa31fc5 ("[PATCH] RTC subsystem: DS1672 driver")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/rtc/rtc-ds1672.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/rtc/rtc-ds1672.c b/drivers/rtc/rtc-ds1672.c
    index 9caaccccaa575..b1ebca099b0df 100644
    --- a/drivers/rtc/rtc-ds1672.c
    +++ b/drivers/rtc/rtc-ds1672.c
    @@ -58,7 +58,8 @@ static int ds1672_get_datetime(struct i2c_client *client, struct rtc_time *tm)
    "%s: raw read data - counters=%02x,%02x,%02x,%02x\n",
    __func__, buf[0], buf[1], buf[2], buf[3]);

    - time = (buf[3] << 24) | (buf[2] << 16) | (buf[1] << 8) | buf[0];
    + time = ((unsigned long)buf[3] << 24) | (buf[2] << 16) |
    + (buf[1] << 8) | buf[0];

    rtc_time_to_tm(time, tm);

    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:08    [W:2.357 / U:3.696 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site