lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 112/639] clk: armada-xp: fix refcount leak in axp_clk_init()
    Date
    From: Yangtao Li <tiny.windzz@gmail.com>

    [ Upstream commit db20a90a4b6745dad62753f8bd2f66afdd5abc84 ]

    The of_find_compatible_node() returns a node pointer with refcount
    incremented, but there is the lack of use of the of_node_put() when
    done. Add the missing of_node_put() to release the refcount.

    Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
    Reviewed-by: Gregory CLEMENT <gregory.clement@bootlin.com>
    Fixes: 0a11a6ae9437 ("clk: mvebu: armada-xp: maintain clock init order")
    Signed-off-by: Stephen Boyd <sboyd@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/clk/mvebu/armada-xp.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/clk/mvebu/armada-xp.c b/drivers/clk/mvebu/armada-xp.c
    index 0ec44ae9a2a26..df529982adc97 100644
    --- a/drivers/clk/mvebu/armada-xp.c
    +++ b/drivers/clk/mvebu/armada-xp.c
    @@ -228,7 +228,9 @@ static void __init axp_clk_init(struct device_node *np)

    mvebu_coreclk_setup(np, &axp_coreclks);

    - if (cgnp)
    + if (cgnp) {
    mvebu_clk_gating_setup(cgnp, axp_gating_desc);
    + of_node_put(cgnp);
    + }
    }
    CLK_OF_DECLARE(axp_clk, "marvell,armada-xp-core-clock", axp_clk_init);
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:05    [W:2.525 / U:1.712 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site