lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 069/639] exportfs: fix passing zero to ERR_PTR() warning
    Date
    From: YueHaibing <yuehaibing@huawei.com>

    [ Upstream commit 909e22e05353a783c526829427e9a8de122fba9c ]

    Fix a static code checker warning:
    fs/exportfs/expfs.c:171 reconnect_one() warn: passing zero to 'ERR_PTR'

    The error path for lookup_one_len_unlocked failure
    should set err to PTR_ERR.

    Fixes: bbf7a8a3562f ("exportfs: move most of reconnect_path to helper function")
    Signed-off-by: YueHaibing <yuehaibing@huawei.com>
    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/exportfs/expfs.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/fs/exportfs/expfs.c b/fs/exportfs/expfs.c
    index 808cae6d5f50f..ae3248326c449 100644
    --- a/fs/exportfs/expfs.c
    +++ b/fs/exportfs/expfs.c
    @@ -147,6 +147,7 @@ static struct dentry *reconnect_one(struct vfsmount *mnt,
    tmp = lookup_one_len_unlocked(nbuf, parent, strlen(nbuf));
    if (IS_ERR(tmp)) {
    dprintk("%s: lookup failed: %d\n", __func__, PTR_ERR(tmp));
    + err = PTR_ERR(tmp);
    goto out_err;
    }
    if (tmp != dentry) {
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:03    [W:2.476 / U:0.412 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site