lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 044/639] drm/msm: fix unsigned comparison with less than zero
    Date
    From: Colin Ian King <colin.king@canonical.com>

    [ Upstream commit dfdb3be43ef1195c491e6c3760b922acb52e3575 ]

    The return from the call to _mixer_stages can be a negative error
    code however this is being assigned to an unsigned variable 'stages'
    hence the check is always false. Fix this by making 'stages' an
    int.

    Detected by Coccinelle ("Unsigned expression compared with zero:
    stages < 0")

    Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Signed-off-by: Rob Clark <robdclark@gmail.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c
    index 06be7cf7ce505..79bafea663542 100644
    --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c
    +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c
    @@ -310,7 +310,7 @@ static void dpu_hw_ctl_setup_blendstage(struct dpu_hw_ctl *ctx,
    u32 mixercfg = 0, mixercfg_ext = 0, mix, ext;
    u32 mixercfg_ext2 = 0, mixercfg_ext3 = 0;
    int i, j;
    - u8 stages;
    + int stages;
    int pipes_per_stage;

    stages = _mixer_stages(ctx->mixer_hw_caps, ctx->mixer_count, lm);
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:01    [W:2.169 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site