lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 008/639] powerpc/archrandom: fix arch_get_random_seed_int()
    Date
    From: Ard Biesheuvel <ardb@kernel.org>

    commit b6afd1234cf93aa0d71b4be4788c47534905f0be upstream.

    Commit 01c9348c7620ec65

    powerpc: Use hardware RNG for arch_get_random_seed_* not arch_get_random_*

    updated arch_get_random_[int|long]() to be NOPs, and moved the hardware
    RNG backing to arch_get_random_seed_[int|long]() instead. However, it
    failed to take into account that arch_get_random_int() was implemented
    in terms of arch_get_random_long(), and so we ended up with a version
    of the former that is essentially a NOP as well.

    Fix this by calling arch_get_random_seed_long() from
    arch_get_random_seed_int() instead.

    Fixes: 01c9348c7620ec65 ("powerpc: Use hardware RNG for arch_get_random_seed_* not arch_get_random_*")
    Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20191204115015.18015-1-ardb@kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/powerpc/include/asm/archrandom.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/powerpc/include/asm/archrandom.h
    +++ b/arch/powerpc/include/asm/archrandom.h
    @@ -28,7 +28,7 @@ static inline int arch_get_random_seed_i
    unsigned long val;
    int rc;

    - rc = arch_get_random_long(&val);
    + rc = arch_get_random_seed_long(&val);
    if (rc)
    *v = val;


    \
     
     \ /
      Last update: 2020-01-24 11:09    [W:2.217 / U:16.524 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site