lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 343/639] RDMA/rxe: Consider skb reserve space based on netdev of GID
    Date
    From: Parav Pandit <parav@mellanox.com>

    [ Upstream commit 3bf3e2b881c1412d0329ce9376dfe1518489b8fc ]

    Always consider the skb reserve space based on netdevice of the GID
    attribute, regardless of vlan or non vlan netdevice.

    Fixes: 43c9fc509fa5 ("rdma_rxe: make rxe work over 802.1q VLAN devices")
    Signed-off-by: Parav Pandit <parav@mellanox.com>
    Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
    Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/infiniband/sw/rxe/rxe_net.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/infiniband/sw/rxe/rxe_net.c b/drivers/infiniband/sw/rxe/rxe_net.c
    index 8094cbaa54a9e..54add70c22b5c 100644
    --- a/drivers/infiniband/sw/rxe/rxe_net.c
    +++ b/drivers/infiniband/sw/rxe/rxe_net.c
    @@ -533,8 +533,9 @@ struct sk_buff *rxe_init_packet(struct rxe_dev *rxe, struct rxe_av *av,
    if (unlikely(!skb))
    goto out;

    - skb_reserve(skb, hdr_len + LL_RESERVED_SPACE(rxe->ndev));
    + skb_reserve(skb, hdr_len + LL_RESERVED_SPACE(ndev));

    + /* FIXME: hold reference to this netdev until life of this skb. */
    skb->dev = ndev;
    if (av->network_type == RDMA_NETWORK_IPV4)
    skb->protocol = htons(ETH_P_IP);
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:42    [W:2.059 / U:3.424 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site