lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 584/639] net: ethernet: stmmac: Fix signedness bug in ipq806x_gmac_of_parse()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 231042181dc9d6122c6faba64e99ccb25f13cc6c ]

    The "gmac->phy_mode" variable is an enum and in this context GCC will
    treat it as an unsigned int so the error handling will never be
    triggered.

    Fixes: b1c17215d718 ("stmmac: add ipq806x glue layer")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c
    index 2c6d7c69c8f74..0d21082ceb93d 100644
    --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c
    +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c
    @@ -191,7 +191,7 @@ static int ipq806x_gmac_of_parse(struct ipq806x_gmac *gmac)
    struct device *dev = &gmac->pdev->dev;

    gmac->phy_mode = of_get_phy_mode(dev->of_node);
    - if (gmac->phy_mode < 0) {
    + if ((int)gmac->phy_mode < 0) {
    dev_err(dev, "missing phy mode property\n");
    return -EINVAL;
    }
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:36    [W:2.205 / U:8.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site