lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 578/639] net: netsec: Fix signedness bug in netsec_probe()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit bd55f8ddbc437c225391ca8f487e7ec10243c4cc ]

    The "priv->phy_interface" variable is an enum and in this context GCC
    will treat it as an unsigned int so the error handling is never
    triggered.

    Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/socionext/netsec.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c
    index d9d0d03e4ce79..027367b9cc480 100644
    --- a/drivers/net/ethernet/socionext/netsec.c
    +++ b/drivers/net/ethernet/socionext/netsec.c
    @@ -1604,7 +1604,7 @@ static int netsec_probe(struct platform_device *pdev)
    NETIF_MSG_LINK | NETIF_MSG_PROBE;

    priv->phy_interface = device_get_phy_mode(&pdev->dev);
    - if (priv->phy_interface < 0) {
    + if ((int)priv->phy_interface < 0) {
    dev_err(&pdev->dev, "missing required property 'phy-mode'\n");
    ret = -ENODEV;
    goto free_ndev;
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:34    [W:2.088 / U:1.528 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site