lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 575/639] cxgb4: Signedness bug in init_one()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 286183147666fb76c057836c57d86e9e6f508bca ]

    The "chip" variable is an enum, and it's treated as unsigned int by GCC
    in this context so the error handling isn't triggered.

    Fixes: e8d452923ae6 ("cxgb4: clean up init_one")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
    index bb04c695ab9fd..c81d6c330548d 100644
    --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
    +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
    @@ -5452,7 +5452,7 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
    whoami = t4_read_reg(adapter, PL_WHOAMI_A);
    pci_read_config_word(pdev, PCI_DEVICE_ID, &device_id);
    chip = t4_get_chip_type(adapter, CHELSIO_PCI_ID_VER(device_id));
    - if (chip < 0) {
    + if ((int)chip < 0) {
    dev_err(&pdev->dev, "Device %d is not supported\n", device_id);
    err = chip;
    goto out_free_adapter;
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:33    [W:2.158 / U:27.996 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site